eschutho commented on PR #35584:
URL: https://github.com/apache/superset/pull/35584#issuecomment-3391740791
The `await` is necessary here to properly manage the loading spinner state.
We need to ensure `setPreparingExport(false)` is only called after the export
completes (or fails). Without `await`, the spinner would disappear immediately
before the download actually happens.
There's no sequential vs parallel processing issue because
`handleResourceExport` is only called once with all selected dashboard IDs -
the backend creates a single zip file containing all dashboards in one API
call. For example, if a user selects 3 dashboards to export, we call:
```typescript
handleResourceExport('dashboard', [1, 2, 3], callback)
```
This makes a single request to `/api/v1/dashboard/export/?q=!(1,2,3)` which
returns one zip file with all three dashboards.
The same pattern applies to all other `handleResourceExport` calls
throughout the PR - they're all exporting a collection of IDs in a single API
call.
(Comment from @elizabeththompson via Claude Code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
