kgabryje commented on code in PR #35584:
URL: https://github.com/apache/superset/pull/35584#discussion_r2418782918
##########
superset-frontend/src/features/home/ChartTable.tsx:
##########
@@ -132,12 +132,17 @@ function ChartTable({
setLoaded(true);
}, [activeTab]);
- const handleBulkChartExport = (chartsToExport: Chart[]) => {
+ const handleBulkChartExport = async (chartsToExport: Chart[]) => {
const ids = chartsToExport.map(({ id }) => id);
- handleResourceExport('chart', ids, () => {
- setPreparingExport(false);
- });
setPreparingExport(true);
+ try {
+ await handleResourceExport('chart', ids, () => {
Review Comment:
Do we actually need to await this? If user tries to export multiple assets,
they’ll be processed sequentially instead of in parallel.
This comment also applies to all other handleResourceExport calls in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
