dpgaspar commented on PR #35345: URL: https://github.com/apache/superset/pull/35345#issuecomment-3384508801
> > How does this work with `APP_ROOT`? Are we going to see any issues? > > I _think_ it works, because we start with `appbuilder.get_url_for_login` which has the `APP_ROOT` prefix. Then we only swap the query string, leaving the base URL alone. Do we have any CI tests that would check that? I'm not deploying with that variable set. yes `appbuilder.get_url_for_login` uses Flask's `url_for` that respects Flask's `APPLICATION_ROOT`. If we want to be extra sure we could add a new test for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
