amaannawab923 commented on code in PR #35343:
URL: https://github.com/apache/superset/pull/35343#discussion_r2459739374
##########
superset/models/helpers.py:
##########
@@ -2057,13 +2060,32 @@ def get_sqla_query( # pylint:
disable=too-many-arguments,too-many-locals,too-ma
rejected_adhoc_filters_columns.append(flt_col)
continue
else:
+ # Check if it's a regular column first
col_obj = columns_by_name.get(cast(str, flt_col))
+ # If not found in columns, check if it's a metric
+ # This supports filtering on metric columns for any chart type
+ if (
+ col_obj is None
+ and isinstance(flt_col, str)
+ and flt_col in metrics_by_name
+ ):
+ # Convert metric to SQLA column expression
+ sqla_col = metrics_by_name[flt_col].get_sqla_col(
+ template_processor=template_processor
+ )
+ is_metric_filter = True
Review Comment:
Why do we need the is_metric_filter flag , the backend already handles it if
you pass it in having clause for extras.having
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
