geido commented on code in PR #35343:
URL: https://github.com/apache/superset/pull/35343#discussion_r2459719136
##########
superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.jsx:
##########
@@ -537,7 +576,13 @@ const Chart = props => {
formData={formData}
labelsColor={labelsColor}
labelsColorMap={labelsColorMap}
- ownState={dataMask[props.id]?.ownState}
+ ownState={{
+ ...dataMask[props.id]?.ownState,
+ ...(hasChartStateConverter(slice.viz_type) &&
+ chartStates[props.id]?.state
+ ? { savedAgGridState: chartStates[props.id].state }
Review Comment:
Do we still need this?
##########
superset/dashboards/permalink/schemas.py:
##########
@@ -52,6 +52,16 @@ class DashboardPermalinkStateSchema(Schema):
allow_none=True,
metadata={"description": "Optional anchor link added to url hash"},
)
+ chartStates = fields.Dict( # noqa: N815
+ required=False,
+ allow_none=True,
+ metadata={
+ "description": (
+ "Chart-level state for AG Grid tables "
Review Comment:
Should this be generalized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
