eschutho commented on code in PR #35506:
URL: https://github.com/apache/superset/pull/35506#discussion_r2461277721


##########
superset-frontend/package.json:
##########
@@ -48,11 +48,16 @@
     "cover": "cross-env NODE_ENV=test 
NODE_OPTIONS=\"--max-old-space-size=4096\" jest --coverage",
     "dev": "webpack --mode=development --color --watch",
     "dev-server": "cross-env NODE_ENV=development BABEL_ENV=development node 
--max_old_space_size=4096 
./node_modules/webpack-dev-server/bin/webpack-dev-server.js --mode=development",
-    "eslint": "eslint --ignore-path=.eslintignore --ext .js,.jsx,.ts,tsx 
--quiet",

Review Comment:
   To avoid breaking CI pipelines for downstream Superset users who may still 
be calling npm run eslint, can we keep the eslint script for now and have it 
call npm run lint under the hood? We can then add a note to UPDATING.md that 
the command is deprecated and will be removed in a future release. This gives 
consumers a safer migration path while we switch to OXC.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to