rusackas commented on code in PR #35506:
URL: https://github.com/apache/superset/pull/35506#discussion_r2461981746
##########
superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-theme/Theme.stories.tsx:
##########
@@ -66,15 +59,17 @@ const AntDFunctionalColors = () => {
<strong>{type}</strong>
</td>
{variants.map(variant => {
- const color = themeObject.getColorVariants(type)[variant];
+ // Map to actual theme token names
+ const tokenName = `color${type.charAt(0).toUpperCase() +
type.slice(1)}${variant.charAt(0).toUpperCase() + variant.slice(1)}`;
Review Comment:
This falls into the "technically correct but not worth the complexity for
demo code" category. If this were production application code used in multiple
places, I'd
say yes. But for a single-use storybook demo, the current approach is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
