richardfogaca opened a new pull request, #35834:
URL: https://github.com/apache/superset/pull/35834
### SUMMARY
Fixes a bug where new dashboard tabs would show their content as cut off
at the bottom. This was caused by tabs not filling the full available height,
resulting in content being clipped outside the visible area.
The fix introduces a `fullHeight` prop to the Tabs component that cascades
`height: 100%` through the tab hierarchy (`.ant-tabs` →
`.ant-tabs-content-holder` → `.ant-tabs-content` → `.ant-tabs-tabpane`). This
ensures tabs expand to fill their container's height while maintaining proper
layout.
Additionally, it updates the `DashboardEmptyStateContainer` to use flexbox
centering while preserving `position: absolute` to prevent excessive whitespace
in empty tabs.
**Changes:**
- Added `fullHeight` prop to `Tabs` component in `superset-ui-core`
- Applied `fullHeight` to both top-level and nested dashboard tabs
- Changed `height: inherit` to `height: 100%` in `DashboardBuilder` for
the ParentSize wrapper
- Added flexbox centering to `DashboardEmptyStateContainer` while keeping
absolute positioning
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**BEFORE:** New dashboard tabs showed content cut off at the bottom,
requiring scrolling to see full content
<img width="720" height="280" alt="image (3)"
src="https://github.com/user-attachments/assets/2a06ec30-b2d7-4660-8aee-6961a266c7a3";
/>
**AFTER:** Dashboard tabs now properly fill available height, with content
fully visible and no excessive whitespace in empty tabs
<img width="1512" height="982" alt="Screenshot 2025-10-24 at 18 12 00"
src="https://github.com/user-attachments/assets/69420395-89e8-4eb6-ae74-cf8c95258df5";
/>
### TESTING INSTRUCTIONS
1. Navigate to any dashboard
2. Click "Edit dashboard"
3. Click "Add tab" to create a new empty tab
4. Save
5. Verify the empty state message is centered and there's no excessive
blank space below
6. Switch to existing tabs with content
7. Verify all charts and components are fully visible without being cut off
8. Verify no excessive scrolling is required to see content
### ADDITIONAL INFORMATION
- [x] Changes UI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
