bito-code-review[bot] commented on PR #35834:
URL: https://github.com/apache/superset/pull/35834#issuecomment-3445009116
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant DB as DashboardBuilder<br/>🔄 Updated | ●●○ Medium
participant DC as DashboardContainer<br/>🔄 Updated | ●●○ Medium
participant Tabs as Tabs Component<br/>🔄 Updated | ●●● High
participant TR as TabsRenderer<br/>🔄 Updated | ●●○ Medium
participant DG as DashboardGrid<br/>🔄 Updated | ●●○ Medium
participant DOM as DOM/Browser Rendering
Note over Tabs: fullHeight prop added to enable<br/>100% height CSS styling
DB->>DC: Render DashboardContainer
DC->>Tabs: Pass fullHeight prop
Tabs->>TR: Propagate fullHeight config
TR->>DOM: Render tabs with height: 100%
DG->>DOM: Render empty state with flex centering
DOM-->>DB: Responsive tab layout
```
Critical path: DashboardBuilder -> DashboardContainer -> Tabs
Component -> TabsRenderer -> DOM/Browser Rendering
> **Note:** The diff introduces a fullHeight prop to the Tabs component to
enable proper CSS height inheritance for dashboard tab containers.
DashboardContainer now passes this prop through to Tabs and TabsRenderer,
enabling full-height rendering of tab content. Additionally, DashboardGrid and
DashboardBuilder receive styling updates for proper layout alignment.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
