sfirke commented on PR #35848: URL: https://github.com/apache/superset/pull/35848#issuecomment-3451535806
Thanks for this! I am trying to understand why the current version is what it is, given that your version is much clearer and shorter. I traced back to the original PR that complicated things: https://github.com/apache/superset/pull/2545 Do you have any guess why they went from `DAY({col})` to: ``` CAST({col} as TIMESTAMP)' ' - HOUR({col}) HOURS' ' - MINUTE({col}) MINUTES' ' - SECOND({col}) SECONDS' ' - MICROSECOND({col}) MICROSECONDS ') ``` ? Should the change you made be made also to SECOND, MINUTE, and HOUR which look like they use similar structures? I am unfamiliar with DB2 and would love if someone could explain to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
