msyavuz commented on code in PR #35478:
URL: https://github.com/apache/superset/pull/35478#discussion_r2469133730
##########
superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.jsx:
##########
@@ -157,6 +159,10 @@ const Chart = props => {
const maxRows = useSelector(
state => state.dashboardInfo.common.conf.SQL_MAX_ROW,
);
+ const streamingThreshold = useSelector(
+ state =>
+ state.dashboardInfo.common.conf.CSV_STREAMING_ROW_THRESHOLD || 100000,
Review Comment:
Should this be a constant default or a config even?
##########
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##########
@@ -351,21 +395,47 @@ const ResultSet = ({
css={copyButtonStyles}
buttonSize="small"
buttonStyle="secondary"
- href={getExportCsvUrl(query.id)}
+ href={
+ !shouldUseStreamingExport()
+ ? getExportCsvUrl(query.id)
+ : undefined
+ }
data-test="export-csv-button"
- onClick={() => {
- logAction(LOG_ACTIONS_SQLLAB_DOWNLOAD_CSV, {});
- if (
- limitingFactor === LimitingFactor.Dropdown &&
- limit === rowsCount
- ) {
- Modal.warning({
- title: t('Download is on the way'),
- content: t(
- 'Downloading %(rows)s rows based on the LIMIT
configuration. If you want the entire result set, you need to adjust the
LIMIT.',
- { rows: rowsCount.toLocaleString() },
- ),
+ onClick={e => {
+ const useStreaming = shouldUseStreamingExport();
+
+ if (useStreaming) {
+ e.preventDefault();
+ setShowStreamingModal(true);
+
+ const timestamp = new Date()
+ .toISOString()
+ .slice(0, 19)
+ .replace(/[-:]/g, '')
+ .replace('T', '_');
+ const filename = `sqllab_${query.id}_${timestamp}.csv`;
Review Comment:
Should this be handled on the backend?
##########
superset-frontend/src/components/StreamingExportModal/StreamingExportModal.tsx:
##########
@@ -0,0 +1,405 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled, t, useTheme } from '@superset-ui/core';
+import { Modal, Button, Typography, Progress } from 'antd';
Review Comment:
Can we import from the core instead of antd directly?
##########
superset-frontend/src/components/StreamingExportModal/StreamingExportModal.tsx:
##########
@@ -0,0 +1,403 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/* eslint-disable theme-colors/no-literal-colors */
+import { styled, t } from '@superset-ui/core';
+import { Modal, Button, Typography, Progress } from 'antd';
+import { Icons } from '@superset-ui/core/components/Icons';
+
+const { Text } = Typography;
+
+export enum ExportStatus {
+ STREAMING = 'streaming',
+ COMPLETED = 'completed',
+ ERROR = 'error',
+ CANCELLED = 'cancelled',
+}
+
+export interface StreamingProgress {
+ totalRows?: number;
+ rowsProcessed: number;
+ totalSize: number;
+ status: ExportStatus;
+ downloadUrl?: string;
+ error?: string;
+ filename?: string;
+ speed?: number;
+ mbPerSecond?: number;
+ elapsedTime?: number;
+ retryCount?: number;
+}
+
+interface StreamingExportModalProps {
+ visible: boolean;
+ onCancel: () => void;
+ onRetry?: () => void;
+ progress: StreamingProgress;
+}
+
+const ModalContent = styled.div`
+ padding: ${({ theme }) => theme.sizeUnit * 4}px 0
+ ${({ theme }) => theme.sizeUnit * 2}px;
+`;
+
+const ProgressSection = styled.div`
+ margin: ${({ theme }) => theme.sizeUnit * 6}px 0;
+ position: relative;
+`;
+
+const ProgressWrapper = styled.div`
+ display: flex;
+ align-items: center;
+ gap: ${({ theme }) => theme.sizeUnit * 3}px;
+`;
+
+const SuccessIcon = styled(Icons.CheckCircleFilled)`
+ color: #52c41a;
+ font-size: 24px;
+ flex-shrink: 0;
+`;
+
+const ErrorIconWrapper = styled.div`
+ display: flex;
+ align-items: center;
+ justify-content: center;
+ width: 16px;
+ height: 16px;
+ background-color: #ff4d4f;
+ border-radius: 50%;
+ flex-shrink: 0;
+`;
+
+const ErrorIconStyled = styled(Icons.CloseOutlined)`
+ color: white;
+ font-size: 10px;
+`;
+
+const ActionButtons = styled.div`
+ display: flex;
+ gap: ${({ theme }) => theme.sizeUnit * 2}px;
+ justify-content: flex-end;
+`;
+
+const ProgressText = styled(Text)`
+ display: block;
+ text-align: center;
+ margin-top: ${({ theme }) => theme.sizeUnit * 4}px;
+`;
+
+const ErrorText = styled(Text)`
+ display: block;
+ text-align: center;
+ margin-top: ${({ theme }) => theme.sizeUnit * 4}px;
+`;
+
+const CancelButton = styled(Button)`
+ background-color: #f0fff8;
+ color: #1c997a;
+ border-color: #f0fff8;
+
+ &:hover {
+ background-color: #f0fff8;
+ color: #1c997a;
+ border-color: #1c997a;
+ }
+
+ &:focus {
+ background-color: #f0fff8;
+ color: #1c997a;
+ border-color: #1c997a;
+ }
+`;
+
+const DownloadButton = styled(Button)`
+ &.ant-btn-primary {
+ background-color: #2ec196;
+ border-color: #2ec196;
+ color: #ffffff;
+
+ &:hover:not(:disabled) {
+ background-color: #26a880;
+ border-color: #26a880;
+ color: #ffffff;
+ }
+
+ &:focus:not(:disabled) {
+ background-color: #2ec196;
+ border-color: #2ec196;
+ color: #ffffff;
+ }
+
+ &:disabled {
+ background-color: #f2f2f2;
+ border-color: #f2f2f2;
+ color: #b5b5b5;
+ }
+ }
+`;
+
+interface ModalStateContentProps {
+ status: ExportStatus;
+ progress: StreamingProgress;
+ onCancel: () => void;
+ onRetry?: () => void;
+ onDownload: () => void;
+ getProgressPercentage: () => number;
+}
+
+const ErrorContent = ({
+ error,
+ onCancel,
+ onRetry,
+ getProgressPercentage,
+}: {
+ error?: string;
+ onCancel: () => void;
+ onRetry?: () => void;
+ getProgressPercentage: () => number;
+}) => (
+ <ModalContent>
+ <ProgressSection>
+ <ProgressWrapper>
+ <Progress
+ percent={getProgressPercentage()}
+ status="exception"
+ showInfo={false}
+ style={{ flex: 1 }}
Review Comment:
I don't think this is resolved
##########
superset-frontend/src/components/StreamingExportModal/StreamingExportModal.tsx:
##########
@@ -0,0 +1,405 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled, t, useTheme } from '@superset-ui/core';
+import { Modal, Button, Typography, Progress } from 'antd';
+import { Icons } from '@superset-ui/core/components/Icons';
+
+const { Text } = Typography;
+
+export enum ExportStatus {
+ STREAMING = 'streaming',
+ COMPLETED = 'completed',
+ ERROR = 'error',
+ CANCELLED = 'cancelled',
+}
+
+export interface StreamingProgress {
+ totalRows?: number;
+ rowsProcessed: number;
+ totalSize: number;
+ status: ExportStatus;
+ downloadUrl?: string;
+ error?: string;
+ filename?: string;
+ speed?: number;
+ mbPerSecond?: number;
+ elapsedTime?: number;
+ retryCount?: number;
+}
+
+interface StreamingExportModalProps {
+ visible: boolean;
+ onCancel: () => void;
+ onRetry?: () => void;
+ progress: StreamingProgress;
+}
+
+const ModalContent = styled.div`
+ padding: ${({ theme }) => theme.sizeUnit * 4}px 0
+ ${({ theme }) => theme.sizeUnit * 2}px;
+`;
+
+const ProgressSection = styled.div`
+ margin: ${({ theme }) => theme.sizeUnit * 6}px 0;
+ position: relative;
+`;
+
+const ProgressWrapper = styled.div`
+ display: flex;
+ align-items: center;
+ gap: ${({ theme }) => theme.sizeUnit * 3}px;
+`;
+
+const SuccessIcon = styled(Icons.CheckCircleFilled)`
+ color: ${({ theme }) => theme.colorSuccess};
+ font-size: 24px;
+ flex-shrink: 0;
+`;
+
+const ErrorIconWrapper = styled.div`
+ display: flex;
+ align-items: center;
+ justify-content: center;
+ width: 16px;
+ height: 16px;
+ background-color: ${({ theme }) => theme.colorError};
+ border-radius: 50%;
+ flex-shrink: 0;
+`;
+
+const ErrorIconStyled = styled(Icons.CloseOutlined)`
+ color: ${({ theme }) => theme.colorWhite};
+ font-size: 10px;
+`;
+
+const ActionButtons = styled.div`
+ display: flex;
+ gap: ${({ theme }) => theme.sizeUnit * 2}px;
+ justify-content: flex-end;
+`;
+
+const ProgressText = styled(Text)`
+ display: block;
+ text-align: center;
+ margin-top: ${({ theme }) => theme.sizeUnit * 4}px;
+`;
+
+const ErrorText = styled(Text)`
+ display: block;
+ text-align: center;
+ margin-top: ${({ theme }) => theme.sizeUnit * 4}px;
+`;
+
+const CancelButton = styled(Button)`
+ background-color: ${({ theme }) => theme.colorSuccessBg};
+ color: ${({ theme }) => theme.colorSuccess};
+ border-color: ${({ theme }) => theme.colorSuccessBg};
+
+ &:hover {
+ background-color: ${({ theme }) => theme.colorSuccessBg};
+ color: ${({ theme }) => theme.colorSuccess};
+ border-color: ${({ theme }) => theme.colorSuccess};
+ }
+
+ &:focus {
+ background-color: ${({ theme }) => theme.colorSuccessBg};
+ color: ${({ theme }) => theme.colorSuccess};
+ border-color: ${({ theme }) => theme.colorSuccess};
+ }
+`;
+
+const DownloadButton = styled(Button)`
+ &.ant-btn-primary {
+ background-color: ${({ theme }) => theme.colorSuccess};
+ border-color: ${({ theme }) => theme.colorSuccess};
+ color: ${({ theme }) => theme.colorWhite};
+
+ &:hover:not(:disabled) {
+ background-color: ${({ theme }) => theme.colorSuccessActive};
+ border-color: ${({ theme }) => theme.colorSuccessActive};
+ color: ${({ theme }) => theme.colorWhite};
+ }
+
+ &:focus:not(:disabled) {
+ background-color: ${({ theme }) => theme.colorSuccess};
+ border-color: ${({ theme }) => theme.colorSuccess};
+ color: ${({ theme }) => theme.colorWhite};
+ }
+
+ &:disabled {
+ background-color: ${({ theme }) => theme.colorBgContainerDisabled};
+ border-color: ${({ theme }) => theme.colorBgContainerDisabled};
+ color: ${({ theme }) => theme.colorTextDisabled};
+ }
+ }
+`;
+
+interface ModalStateContentProps {
+ status: ExportStatus;
+ progress: StreamingProgress;
+ onCancel: () => void;
+ onRetry?: () => void;
+ onDownload: () => void;
+ getProgressPercentage: () => number;
+}
+
+const ErrorContent = ({
+ error,
+ onCancel,
+ onRetry,
+ getProgressPercentage,
+}: {
+ error?: string;
+ onCancel: () => void;
+ onRetry?: () => void;
+ getProgressPercentage: () => number;
+}) => (
+ <ModalContent>
+ <ProgressSection>
+ <ProgressWrapper>
+ <Progress
+ percent={getProgressPercentage()}
+ status="exception"
+ showInfo={false}
+ style={{ flex: 1 }}
+ />
+ <ErrorIconWrapper>
+ <ErrorIconStyled />
+ </ErrorIconWrapper>
+ </ProgressWrapper>
+ <ErrorText type="danger">{error || t('Export failed')}</ErrorText>
+ </ProgressSection>
+ <ActionButtons>
+ <CancelButton onClick={onCancel}>{t('Close')}</CancelButton>
+ {onRetry && (
+ <DownloadButton type="primary" onClick={onRetry}>
+ {t('Retry')}
+ </DownloadButton>
+ )}
+ </ActionButtons>
+ </ModalContent>
+);
+
+const CancelledContent = ({
+ getProgressPercentage,
+ onCancel,
+ onRetry,
+}: {
+ getProgressPercentage: () => number;
+ onCancel: () => void;
+ onRetry?: () => void;
+}) => (
+ <ModalContent>
+ <ProgressSection>
+ <Progress
+ percent={getProgressPercentage()}
+ status="exception"
+ showInfo={false}
+ />
+ <ProgressText>{t('Export cancelled')}</ProgressText>
+ </ProgressSection>
+ <ActionButtons>
+ <CancelButton onClick={onCancel}>{t('Close')}</CancelButton>
+ {onRetry && (
+ <DownloadButton type="primary" onClick={onRetry}>
+ {t('Retry')}
+ </DownloadButton>
+ )}
+ </ActionButtons>
+ </ModalContent>
+);
+
+const CompletedContent = ({
+ filename,
+ downloadUrl,
+ onCancel,
+ onDownload,
+}: {
+ filename?: string;
+ downloadUrl?: string;
+ onCancel: () => void;
+ onDownload: () => void;
+}) => (
+ <ModalContent>
+ <ProgressSection>
+ <ProgressWrapper>
+ <Progress
+ percent={100}
+ status="success"
+ showInfo={false}
+ style={{ flex: 1 }}
+ />
+ <SuccessIcon />
+ </ProgressWrapper>
+ <ProgressText>
+ {t('Export successful: %s', filename || 'export')}
+ </ProgressText>
+ </ProgressSection>
+ <ActionButtons>
+ <CancelButton onClick={onCancel}>{t('Close')}</CancelButton>
+ <DownloadButton
+ type="primary"
+ onClick={onDownload}
+ disabled={!downloadUrl}
+ >
+ {t('Download')}
+ </DownloadButton>
+ </ActionButtons>
+ </ModalContent>
+);
+
+const StreamingContent = ({
+ filename,
+ getProgressPercentage,
+ onCancel,
+}: {
+ filename?: string;
+ getProgressPercentage: () => number;
+ onCancel: () => void;
+}) => {
+ const theme = useTheme();
+ return (
+ <ModalContent>
+ <ProgressSection>
+ <Progress
+ percent={getProgressPercentage()}
+ status="normal"
+ strokeColor={theme.colorSuccess}
+ showInfo
+ format={percent => `${Math.round(percent || 0)}%`}
+ />
+ <ProgressText>
+ {filename
+ ? t('Processing export for %s', filename)
+ : t('Processing export...')}
+ </ProgressText>
+ </ProgressSection>
+ <ActionButtons>
+ <CancelButton onClick={onCancel}>{t('Cancel')}</CancelButton>
+ <DownloadButton type="primary" disabled>
+ {t('Download')}
+ </DownloadButton>
+ </ActionButtons>
+ </ModalContent>
+ );
+};
+
+const ModalStateContent = ({
+ status,
+ progress,
+ onCancel,
+ onRetry,
+ onDownload,
+ getProgressPercentage,
+}: ModalStateContentProps) => {
+ const { downloadUrl, filename, error } = progress;
+
+ switch (status) {
+ case ExportStatus.ERROR:
+ return (
+ <ErrorContent
+ error={error}
+ onCancel={onCancel}
+ onRetry={onRetry}
+ getProgressPercentage={getProgressPercentage}
+ />
+ );
+ case ExportStatus.CANCELLED:
+ return (
+ <CancelledContent
+ getProgressPercentage={getProgressPercentage}
+ onCancel={onCancel}
+ onRetry={onRetry}
+ />
+ );
+ case ExportStatus.COMPLETED:
+ return (
+ <CompletedContent
+ filename={filename}
+ downloadUrl={downloadUrl}
+ onCancel={onCancel}
+ onDownload={onDownload}
+ />
+ );
+ default:
+ return (
+ <StreamingContent
+ filename={filename}
+ getProgressPercentage={getProgressPercentage}
+ onCancel={onCancel}
+ />
+ );
+ }
Review Comment:
These components look very similar. Should we make the props conditional
instead of the components?
##########
superset-frontend/src/components/StreamingExportModal/useStreamingExport.ts:
##########
@@ -0,0 +1,367 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { useState, useCallback, useRef, useEffect } from 'react';
+import { SupersetClient } from '@superset-ui/core';
+import { ExportStatus, StreamingProgress } from './StreamingExportModal';
+
+interface UseStreamingExportOptions {
+ onComplete?: (downloadUrl: string, filename: string) => void;
+ onError?: (error: string) => void;
+}
+
+interface StreamingExportPayload {
+ [key: string]: unknown;
+}
Review Comment:
I would prefer `Record<string, unknown>` here
##########
superset-frontend/src/components/StreamingExportModal/StreamingExportModal.tsx:
##########
@@ -0,0 +1,405 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled, t, useTheme } from '@superset-ui/core';
+import { Modal, Button, Typography, Progress } from 'antd';
+import { Icons } from '@superset-ui/core/components/Icons';
+
+const { Text } = Typography;
+
+export enum ExportStatus {
+ STREAMING = 'streaming',
+ COMPLETED = 'completed',
+ ERROR = 'error',
+ CANCELLED = 'cancelled',
+}
+
+export interface StreamingProgress {
+ totalRows?: number;
+ rowsProcessed: number;
+ totalSize: number;
+ status: ExportStatus;
+ downloadUrl?: string;
+ error?: string;
+ filename?: string;
+ speed?: number;
+ mbPerSecond?: number;
+ elapsedTime?: number;
+ retryCount?: number;
+}
+
+interface StreamingExportModalProps {
+ visible: boolean;
+ onCancel: () => void;
+ onRetry?: () => void;
+ progress: StreamingProgress;
+}
+
+const ModalContent = styled.div`
+ padding: ${({ theme }) => theme.sizeUnit * 4}px 0
+ ${({ theme }) => theme.sizeUnit * 2}px;
+`;
+
+const ProgressSection = styled.div`
+ margin: ${({ theme }) => theme.sizeUnit * 6}px 0;
+ position: relative;
+`;
+
+const ProgressWrapper = styled.div`
+ display: flex;
+ align-items: center;
+ gap: ${({ theme }) => theme.sizeUnit * 3}px;
+`;
+
+const SuccessIcon = styled(Icons.CheckCircleFilled)`
+ color: ${({ theme }) => theme.colorSuccess};
+ font-size: 24px;
+ flex-shrink: 0;
+`;
+
+const ErrorIconWrapper = styled.div`
+ display: flex;
+ align-items: center;
+ justify-content: center;
+ width: 16px;
+ height: 16px;
+ background-color: ${({ theme }) => theme.colorError};
+ border-radius: 50%;
+ flex-shrink: 0;
+`;
+
+const ErrorIconStyled = styled(Icons.CloseOutlined)`
+ color: ${({ theme }) => theme.colorWhite};
+ font-size: 10px;
+`;
+
+const ActionButtons = styled.div`
+ display: flex;
+ gap: ${({ theme }) => theme.sizeUnit * 2}px;
+ justify-content: flex-end;
+`;
+
+const ProgressText = styled(Text)`
+ display: block;
+ text-align: center;
+ margin-top: ${({ theme }) => theme.sizeUnit * 4}px;
+`;
+
+const ErrorText = styled(Text)`
+ display: block;
+ text-align: center;
+ margin-top: ${({ theme }) => theme.sizeUnit * 4}px;
+`;
+
+const CancelButton = styled(Button)`
+ background-color: ${({ theme }) => theme.colorSuccessBg};
+ color: ${({ theme }) => theme.colorSuccess};
+ border-color: ${({ theme }) => theme.colorSuccessBg};
+
+ &:hover {
+ background-color: ${({ theme }) => theme.colorSuccessBg};
+ color: ${({ theme }) => theme.colorSuccess};
+ border-color: ${({ theme }) => theme.colorSuccess};
+ }
+
+ &:focus {
+ background-color: ${({ theme }) => theme.colorSuccessBg};
+ color: ${({ theme }) => theme.colorSuccess};
+ border-color: ${({ theme }) => theme.colorSuccess};
+ }
+`;
+
+const DownloadButton = styled(Button)`
+ &.ant-btn-primary {
+ background-color: ${({ theme }) => theme.colorSuccess};
+ border-color: ${({ theme }) => theme.colorSuccess};
+ color: ${({ theme }) => theme.colorWhite};
+
+ &:hover:not(:disabled) {
+ background-color: ${({ theme }) => theme.colorSuccessActive};
+ border-color: ${({ theme }) => theme.colorSuccessActive};
+ color: ${({ theme }) => theme.colorWhite};
+ }
+
+ &:focus:not(:disabled) {
+ background-color: ${({ theme }) => theme.colorSuccess};
+ border-color: ${({ theme }) => theme.colorSuccess};
+ color: ${({ theme }) => theme.colorWhite};
+ }
+
+ &:disabled {
+ background-color: ${({ theme }) => theme.colorBgContainerDisabled};
+ border-color: ${({ theme }) => theme.colorBgContainerDisabled};
+ color: ${({ theme }) => theme.colorTextDisabled};
+ }
+ }
Review Comment:
Can we clean this up a bit? use a single function and maybe check if some of
this is even necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
