amaannawab923 commented on code in PR #35478:
URL: https://github.com/apache/superset/pull/35478#discussion_r2471972791
##########
superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.jsx:
##########
@@ -157,6 +159,10 @@ const Chart = props => {
const maxRows = useSelector(
state => state.dashboardInfo.common.conf.SQL_MAX_ROW,
);
+ const streamingThreshold = useSelector(
+ state =>
+ state.dashboardInfo.common.conf.CSV_STREAMING_ROW_THRESHOLD || 100000,
Review Comment:
I liked the idea of it being configurable if someone wants to enable
streaming at different thresholds as per needs , Should we make it hardcoded
@geido or is it fine as configured
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
