sadpandajoe commented on PR #35810:
URL: https://github.com/apache/superset/pull/35810#issuecomment-3458791928
> @sadpandajoe is there somewhere we're encountering this error that we
should be looking at for validation (of the fix, and the problem)?
@rusackas yes, when looking at the jest tests, we should see a reduction of
the following errors compared to master. This right now only cleans up some
files, i'll have follow up prs for other ones, I just want to have smaller PRs
to review. Here are the errors we're cleaning up:
>/app/superset-frontend/node_modules/react-dom/cjs/react-dom.development.js:3901
throw Error( "The `document` global was defined when React was
initialized, but is not defined anymore. This can happen in a test environment
if a component schedules an update from an asynchronous callback, but the test
has already finished running. To solve this, you can either unmount the
component at the end of your test (and ensure that any asynchronous operations
get canceled in `componentWillUnmount`), or you can change the test itself to
be asynchronous." );
^
[Error: The `document` global was defined when React was initialized, but is
not defined anymore. This can happen in a test environment if a component
schedules an update from an asynchronous callback, but the test has already
finished running. To solve this, you can either unmount the component at the
end of your test (and ensure that any asynchronous operations get canceled in
`componentWillUnmount`), or you can change the test itself to be asynchronous.]
Problem is you can see them but the jest tests are still green so these
errors are either being silenced or something else is going on. You can see
that the jest tests for shard 1 still has them, but it doesn't look like it's
related to these files I've touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
