korbit-ai[bot] commented on code in PR #35897:
URL: https://github.com/apache/superset/pull/35897#discussion_r2475711915
##########
superset-frontend/src/explore/components/controls/ConditionalFormattingControl/types.ts:
##########
@@ -58,4 +59,5 @@ export type FormattingPopoverProps = PopoverProps & {
export type ConditionalFormattingFlag = {
toAllRowCheck?: boolean;
toColorTextCheck?: boolean;
+ toCellBarCheck?: boolean;
};
Review Comment:
I see, thanks for clarifying. Is there a specific reason for using different
naming conventions between ConditionalFormattingConfig and
ConditionalFormattingFlag? If not, would aligning them improve consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
