betodealmeida commented on code in PR #35553: URL: https://github.com/apache/superset/pull/35553#discussion_r2482058297
########## superset/models/helpers.py: ########## @@ -43,6 +43,7 @@ import pandas as pd import pytz import sqlalchemy as sa +import sqlglot Review Comment: We should not import `sqlglot` outside of `superset/sql/`, any SQL parsing should happen there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
