betodealmeida commented on code in PR #35553:
URL: https://github.com/apache/superset/pull/35553#discussion_r2482103805
##########
superset/models/helpers.py:
##########
@@ -871,6 +872,29 @@ def _process_sql_expression( # pylint:
disable=too-many-arguments
raise QueryObjectValidationError(ex.message) from ex
return expression
+ def _should_quote_identifier(self, expr: str) -> bool:
Review Comment:
```python
>>> import sqlglot
>>> from sqlglot.dialects.postgres import Postgres
>>> Postgres().quote_identifier(sqlglot.exp.Identifier(this="test"),
identify=False)
Identifier(this=test, quoted=False) # not quoted
>>> Postgres().quote_identifier(sqlglot.exp.Identifier(this="test test"),
identify=False)
Identifier(this=test test, quoted=True) # quoted
>>>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
