bito-code-review[bot] commented on code in PR #36059:
URL: https://github.com/apache/superset/pull/36059#discussion_r2511523738
##########
superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx:
##########
@@ -734,9 +734,6 @@ const Select = forwardRef(
popupRender={popupRender}
filterOption={handleFilterOption}
filterSort={sortComparatorWithSearch}
- getPopupContainer={
- getPopupContainer || (triggerNode => triggerNode.parentNode)
- }
headerPosition={headerPosition}
labelInValue={labelInValue}
maxTagCount={actualMaxTagCount}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing getPopupContainer prop in Select
component</b></div>
<div id="fix">
The getPopupContainer prop was removed from StyledSelect, creating
inconsistency with AsyncSelect.tsx where it's still passed. This could break
custom popup positioning if the prop is used. Add it back to ensure consistent
behavior across Select components.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
popupRender={popupRender}
filterOption={handleFilterOption}
filterSort={sortComparatorWithSearch}
getPopupContainer={
getPopupContainer || (triggerNode => triggerNode.parentNode)
}
headerPosition={headerPosition}
labelInValue={labelInValue}
maxTagCount={actualMaxTagCount}
````
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/36059#issuecomment-3513222376>#d4a06f</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
