shivamsahu-tech commented on PR #36059:
URL: https://github.com/apache/superset/pull/36059#issuecomment-3546280807

   Hey @msyavuz @kgabryje ,
   After comparing this component with others and debugging further, I found an 
alternative solution besides rendering the dropdown in document.body.
   
   Here .ant-select-dropdown was getting height: 160px (visible in browser dev 
tools)
   .superset-101v6sl .ant-select-dropdown {
       height: 160px;
   }
   Meanwhile, its child .rc-virtual-list-holder has height: 256px, resulting in 
the dual scrollbar issue.
   
   Adding only height: 'auto' to the dropdownStyle prop allows the parent 
container to expand and accommodate the child's size instead of being 
constrained to 160px, that resolve the dual scrollbar issue, tested locally.
   
   **Changes:** `DatabaseModal/index.tsx` (at line 1137)
   ```typescript
   // OLD
   dropdownStyle={{ maxHeight: 400, overflow: 'auto' }}
   
   // NEW 
   dropdownStyle={{ maxHeight: 400, overflow: 'auto',  height: 'auto' }}
   ```
   
   This is a minimal change (one additional property) and shouldn't affect 
anything else.
   Please review this solution. If it looks good or have better approach, let 
me know, I'll update the file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to