rebenitez1802 commented on code in PR #36137:
URL: https://github.com/apache/superset/pull/36137#discussion_r2534656031
##########
superset/mcp_service/chart/schemas.py:
##########
@@ -632,7 +634,9 @@ def validate_unique_column_labels(self) ->
"TableChartConfig":
class XYChartConfig(BaseModel):
- chart_type: Literal["xy"] = Field("xy", description="Chart type")
+ chart_type: Literal["xy"] = Field(
Review Comment:
Can we add more info to the description like:
```suggestion
chart_type: Literal["xy"] = Field(
...,
description=(
"Chart type discriminator - MUST be 'xy' for XY charts (line,
bar, area, scatter). "
"This field is REQUIRED and tells Superset which chart
configuration schema to use."
)
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
