rebenitez1802 commented on code in PR #36137:
URL: https://github.com/apache/superset/pull/36137#discussion_r2534683694
##########
superset/mcp_service/chart/tool/generate_chart.py:
##########
@@ -59,6 +59,36 @@ async def generate_chart( # noqa: C901
- Set save_chart=False for temporary preview only
- LLM clients MUST display returned chart URL to users
- Embed preview_url as image: 
+ - Use numeric dataset ID or UUID (NOT schema.table_name format)
+ - MUST include chart_type in config (either 'xy' or 'table')
+
Review Comment:
can we add descriptive explanation why this is a constrain
```suggestion
IMPORTANT: The 'chart_type' field in the config is a DISCRIMINATOR that
determines
which chart configuration schema to use. It MUST be included and MUST
match the
other fields in your configuration:
- Use chart_type='xy' for charts with x and y axes (line, bar, area,
scatter)
Required fields: x, y
- Use chart_type='table' for tabular visualizations
Required fields: columns
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
