imad-hl commented on PR #35859: URL: https://github.com/apache/superset/pull/35859#issuecomment-3547032992
> Looks like there are some typescript issues to fix. You might fix some by running `npm run plugins:build` on the frontend. Hi @rusackas Thanks for reviewing! I ran `npm run plugins:build` locally and the Country Map plugin seems to compile successfully. apart from some babel warnings : ``` ( @superset-ui/legacy-plugin-chart-country-map: `isModuleDeclaration` has been deprecated, please migrate to `isImportOrExportDeclaration` @superset-ui/legacy-plugin-chart-country-map: at isModuleDeclaration (/app/superset-frontend/node_modules/@babel/types/lib/validators/generated/index.js:2793:35) @superset-ui/legacy-plugin-chart-country-map: at PluginPass.Program (/app/superset-frontend/node_modules/babel-plugin-lodash/lib/index.js:102:44)) ``` The type script errors seems to come from other plugins, I rebased my branch on the latest master, hope it helps -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
