imad-hl commented on code in PR #35859:
URL: https://github.com/apache/superset/pull/35859#discussion_r2588993371
##########
superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.js:
##########
@@ -41,27 +41,45 @@ const propTypes = {
linearColorScheme: PropTypes.string,
mapBaseUrl: PropTypes.string,
numberFormat: PropTypes.string,
+ onContextMenu: PropTypes.func,
+ emitCrossFilters: PropTypes.bool,
+ setDataMask: PropTypes.func,
+ filterState: PropTypes.object,
+ entity: PropTypes.string,
+ sliceId: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
};
const maps = {};
+// Store zoom state per chart instance
+const zoomStates = {};
Review Comment:
Fixed in 9651b63 : replaced the global `zoomStates` object with a `WeakMap`
to allow garbage collection and prevent memory leaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
