sadpandajoe opened a new pull request, #36176:
URL: https://github.com/apache/superset/pull/36176

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   - Fix intermittent test failure in test_update_v1_response that only occurs 
on MySQL
   - Root cause: MySQL's DATETIME type defaults to second-level precision, 
truncating microseconds
   - When test executes in under one second, last_saved_at timestamps appear 
identical
   
   **Problem:** The assertion chart.last_saved_at != last_saved_before fails on 
MySQL when both timestamps fall within the same second, because MySQL truncates 
microseconds.
   
   **Solution:**
     1. Add time.sleep(1) to guarantee crossing second boundary
     2. Normalize timestamps with .replace(microsecond=0) for database-agnostic 
comparison
   
     This matches the established pattern in 
tests/integration_tests/dashboards/dao_tests.py:52-63.
   
    
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to