Copilot commented on code in PR #36176:
URL: https://github.com/apache/superset/pull/36176#discussion_r2547513402
##########
tests/integration_tests/charts/commands_tests.py:
##########
@@ -370,22 +372,54 @@ class TestChartsUpdateCommand(SupersetTestCase):
@patch("superset.utils.core.g")
@patch("superset.security.manager.g")
@pytest.mark.usefixtures("load_energy_table_with_slice")
- def test_update_v1_response(self, mock_sm_g, mock_c_g, mock_u_g):
- """Test that a chart command updates properties"""
+ def test_update_sets_last_saved_at(self, mock_sm_g, mock_c_g, mock_u_g):
+ """Test that update sets last_saved_at when previously unset"""
pk = db.session.query(Slice).all()[0].id
user = security_manager.find_user(username="admin")
mock_u_g.user = mock_c_g.user = mock_sm_g.user = user
- model_id = pk
- json_obj = {
- "description": "test for update",
- "cache_timeout": None,
- "owners": [user.id],
- }
- command = UpdateChartCommand(model_id, json_obj)
- last_saved_before = db.session.query(Slice).get(pk).last_saved_at
+
+ # Explicitly set last_saved_at to None to test None -> datetime
transition
+ chart_to_update = db.session.query(Slice).get(pk)
+ chart_to_update.last_saved_at = None
+ db.session.commit()
+
+ command = UpdateChartCommand(
+ pk,
+ {"description": "test", "owners": [user.id]},
+ )
+ command.run()
+
+ chart = db.session.query(Slice).get(pk)
+ assert chart.last_saved_at is not None
+ assert chart.last_saved_by == user
+
+ @patch("superset.commands.chart.update.g")
+ @patch("superset.utils.core.g")
+ @patch("superset.security.manager.g")
+ @pytest.mark.usefixtures("load_energy_table_with_slice")
+ def test_update_changes_last_saved_at(self, mock_sm_g, mock_c_g, mock_u_g):
+ """Test that update changes last_saved_at when it already has a
value"""
+ pk = db.session.query(Slice).all()[0].id
+ user = security_manager.find_user(username="admin")
+ mock_u_g.user = mock_c_g.user = mock_sm_g.user = user
+
+ chart_to_update = db.session.query(Slice).get(pk)
+ chart_to_update.last_saved_at = datetime.now()
+ db.session.commit()
Review Comment:
[nitpick] After setting `last_saved_at = datetime.now()` and committing, the
Python object may still contain microseconds that were truncated by MySQL
during the database write. To ensure `last_saved_before` contains the actual
database value (without microseconds), consider querying the chart fresh after
the commit:
```python
chart_to_update = db.session.query(Slice).get(pk)
chart_to_update.last_saved_at = datetime.now()
db.session.commit()
# Refresh to get the database value with truncated microseconds
chart_to_update = db.session.query(Slice).get(pk)
last_saved_before = chart_to_update.last_saved_at
```
This makes the test more explicit and avoids relying on ORM refresh behavior.
```suggestion
db.session.commit()
# Refresh to get the database value with truncated microseconds
chart_to_update = db.session.query(Slice).get(pk)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
