manojshetty2004 commented on PR #36229: URL: https://github.com/apache/superset/pull/36229#issuecomment-3575197375
Thanks for the guidance! I’ve removed the new LESS file and moved the styles into the Emotion-based GlobalStyles as suggested. - Updated `superset-frontend/packages/superset-core/src/ui/theme/GlobalStyles.tsx` to add scoped styles under `.superset-embed`. - These styles only apply when the host app wraps the embed root with `.superset-embed`, so normal Superset dashboards are unaffected. - The gap is now based on the theme grid unit. Please let me know if you’d prefer different spacing or a different place for these rules and I’ll update it. > Here's one place you can take a look at some relevant items: superset-frontend/packages/superset-core/src/ui/theme/GlobalStyles.tsx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
