rusackas commented on PR #36229: URL: https://github.com/apache/superset/pull/36229#issuecomment-3583497141
The code is definitely more acceptable now, but I guess I'm still a little unsure of the use case. Embedded Superset (using the SDK anyway) uses an iframe, so I'm not sure how your host app's CSS would "leak" into your Superset instance. Are these styles to _restore_ Superset defaults (looks like it) or to _alter_ them? It's worth noting that Theming (part of the forthcoming 6.0 release, but still improving) supports embedded use cases, so if you want to _alter_ the look and feel of an embedded dashboard, that would be the way to do it going forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
