amym-li opened a new pull request, #36286: URL: https://github.com/apache/superset/pull/36286
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> To migrate the Header component, the following steps were performed: 1. Renamed the index file from `index.js` => `index.ts` 2. Renamed the component file from `Header.jsx` => `Header.tsx` 3. Made the following type changes in `Header.tsx`: - Replaced the `propTypes` const with an `interface HeaderProps` definition - Created `interface ComponentMeta` for header configuration options - Created `interface ComponentShape` for the header instance - Created `interface HeaderState` for the local state - Created `type HeaderStyleValue` for the `headerSize` field values - Created `type BackgroundStyleValue` for the `background` field values 4. Renamed the test file from `Header.test.jsx` => `Header.test.tsx` 5. Made the following type changes in `Header.test.tsx` - Created `interface HeaderTestProps` to mirror `interface HeaderProps` in `Header.tsx` 6. Addressed all eslint warnings and errors ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> CI and unit tests, confirm that the Header component on the Dashboard page renders as expected. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/9101 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
