rusackas commented on PR #36286:
URL: https://github.com/apache/superset/pull/36286#issuecomment-3628253824
It doesn't look like that test failure is related. I'm re-running it in
hopes that it's just flaky. That said, it does seem fixable, so I or anyone
might wanna open a PR to stabilize that.
Some AI comments for whoever wants to tackle it (in a separate PR most
likely):
> This error means the test is attempting to interact with an element that
was removed or replaced in the DOM between finding and clicking it. This is
common when the UI updates asynchronously (e.g., after a filter, mode change,
or API response).
> To fix this, always query for elements immediately prior to clicking, and
use Cypress' recommended best practices for waiting for UI stability. In the
failing test (see lines 208–209):
```ts
208| setGridMode('list');
209| cy.getBySel('edit-alt').eq(1).click();
```
> **Solution:** Instead of querying and clicking in the same line, wait for
the table to stabilize and use Cypress' .should('be.visible') to ensure the
element is attached:
```ts
setGridMode('list');
cy.getBySel('edit-alt').eq(1).should('be.visible').click();
```
> If asynchronous filter/sorting operations occur, ensure you wait for the
corresponding API requests to finish (use cy.wait on intercepts), or for
loading indicators to disappear:
```ts
setGridMode('list');
cy.get('.loading').should('not.exist');
cy.getBySel('edit-alt').eq(1).should('be.visible').click();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
