aminghadersohi commented on code in PR #36245:
URL: https://github.com/apache/superset/pull/36245#discussion_r2566725282
##########
superset/security/manager.py:
##########
@@ -2280,8 +2308,8 @@ def raise_for_access( # noqa: C901
dashboard: Optional["Dashboard"] = None,
chart: Optional["Slice"] = None,
database: Optional["Database"] = None,
- datasource: Optional["BaseDatasource"] = None,
- query: Optional["Query"] = None,
+ datasource: Optional["BaseDatasource | Explorable"] = None,
+ query: Optional["Query | Explorable"] = None,
Review Comment:
could this be confusing and weakens type safety?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
