betodealmeida commented on code in PR #36245:
URL: https://github.com/apache/superset/pull/36245#discussion_r2566820668
##########
superset/security/manager.py:
##########
@@ -2280,8 +2308,8 @@ def raise_for_access( # noqa: C901
dashboard: Optional["Dashboard"] = None,
chart: Optional["Slice"] = None,
database: Optional["Database"] = None,
- datasource: Optional["BaseDatasource"] = None,
- query: Optional["Query"] = None,
+ datasource: Optional["BaseDatasource | Explorable"] = None,
+ query: Optional["Query | Explorable"] = None,
Review Comment:
Yeah, eventually I want to consolidate this into:
```suggestion
datasource: Explorable | None = None, # no query, just datasource
```
But that requires some modifications to the current code, and I'm trying to
just define the protocol with what we have in place first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
