YousufFFFF commented on PR #36306:
URL: https://github.com/apache/superset/pull/36306#issuecomment-3598483058

   > Looks like there's a lot of stuff being removed/disabled here that would 
be considered breaking changes.
   
   Thanks a lot for the detailed review, this is very helpful.
   I agree that I unintentionally removed/disabled existing legend behaviour 
here.
   I’ll rework the PR to:
   – keep the current legend features (selector buttons, theming, padding/text 
behaviour, legend state persistence),
   – only switch the legend to scroll for horizontal orientations when needed 
to avoid overlap, and
   – add before/after screenshots to demonstrate the issue and the fix.
   I’ll push an updated revision shortly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to