YousufFFFF commented on PR #36306: URL: https://github.com/apache/superset/pull/36306#issuecomment-3604015241
Thanks for the review, @rusackas! 1.)Just to clarify the concern about the All/Inv buttons, they were not removed and still work as expected with the scroll legend. I’ve added a short before/after video in the comment showing: - All → correctly resets all series visibility - Inv → correctly inverts the current selection - All legend items remain accessible inside the scrollable container The scroll mode only changes the legend layout (to prevent overflow), but does not modify the built-in ECharts legend controls. 2.)Regarding the `legend` variable typing — you're right, it's never used as an array. I’ll simplify the type from: LegendComponentOption | LegendComponentOption[] to just: LegendComponentOption Please let me know if you'd like the video embedded directly in the pr summary or if any further adjustments are needed! https://github.com/user-attachments/assets/a84a4292-69a8-43c4-9b1b-6ab3362a2cf4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
