JoshuaJADaniel commented on code in PR #36201:
URL: https://github.com/apache/superset/pull/36201#discussion_r2600580139
##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/controls.ts:
##########
@@ -39,6 +39,7 @@ export function columnChoices(datasource: Dataset |
QueryResponse | null) {
}
export const PRIMARY_COLOR = { r: 0, g: 122, b: 135, a: 1 };
+export const BLACK_COLOR = { r: 0, g: 0, b: 0, a: 1 };
Review Comment:
To be consistent with the existing code (namely `PRIMARY_COLOR`), I am going
to leave it as such. If this is a valid suggestion, you can unresolve this
conversation and I will make the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]