LevisNgigi opened a new pull request, #36490: URL: https://github.com/apache/superset/pull/36490
<!--- fix(logout): clicking logout displays an error notification "invalid username or password" --> ### SUMMARY The logout handler in RightMenu.tsx cleared localStorage but not sessionStorage. If login_attempted was still set from a previous failed login, the login page showed the "Invalid username or password" error after logout. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF BEFORE: <img width="1192" height="856" alt="logout" src="https://github.com/user-attachments/assets/9ff05c97-1dba-423c-90be-dd2150caf5d1"; /> AFTER: <img width="1265" height="1173" alt="Screenshot from 2025-12-10 13-00-13" src="https://github.com/user-attachments/assets/e5e7b667-dd7a-4239-a210-bb228187c316"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
