codeant-ai-for-open-source[bot] commented on PR #36490: URL: https://github.com/apache/superset/pull/36490#issuecomment-3636301612
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36490/files#diff-fe59770000288da9bca75381ca9b5d44d076cba76c37a653881a12763ecbf96eR344-R346'><strong>Storage access error</strong></a><br>Direct access to sessionStorage can throw (e.g., in SSR, private browsing or when storage is disabled), which would raise an exception during logout and possibly block navigation. This needs a safe access pattern (try/catch or feature-detection) around storage operations.<br> - [ ] <a href='https://github.com/apache/superset/pull/36490/files#diff-21610747c0968cc22f29ad1373e2ac8034bb7e42f397daf61d2138b5b1349161R381-R386'><strong>Test isolation</strong></a><br>The test now writes to sessionStorage (key `login_attempted`) but the test suite does not clear sessionStorage in teardown. This can leak state across tests and cause flakiness.<br> - [ ] <a href='https://github.com/apache/superset/pull/36490/files#diff-21610747c0968cc22f29ad1373e2ac8034bb7e42f397daf61d2138b5b1349161R389-R399'><strong>Flaky assertion / race</strong></a><br>The test waits for the storage to be cleared after clicking "Logout". Depending on how logout is implemented (navigation, async handler), the timing may vary and produce intermittent failures. Consider spying on removeItem or asserting the logout-side effect more directly.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
