codeant-ai-for-open-source[bot] commented on code in PR #36669:
URL: https://github.com/apache/superset/pull/36669#discussion_r2622194880
##########
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx:
##########
@@ -95,10 +95,13 @@ const TitleLink = styled.span`
const TitleRight = styled.span`
${({ theme }) => css`
position: absolute;
- right: -1px;
font-weight: 400;
bottom: ${theme.sizeUnit * 3}px;
right: ${theme.sizeUnit * 2}px;
+ max-width: 120px;
Review Comment:
**Suggestion:** The added hardcoded `max-width: 120px;` can break in
non-English locales (longer text) and is not consistent with theme sizing;
replace the fixed pixel value with a theme-based value so the width scales with
the app's spacing units. [configuration issue]
**Severity Level:** Minor ⚠️
```suggestion
max-width: ${theme.sizeUnit * 15}px;
```
<details>
<summary><b>Why it matters? ⭐ </b></summary>
Replacing a hardcoded pixel width with a theme-based sizeUnit-backed value
is sensible — it improves consistency with the rest of the app and helps with
scaling/localization. The change is small, safe, and aligns with the file's
existing style patterns (other sizes use theme.sizeUnit).
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx
**Line:** 101:101
**Comment:**
*Configuration Issue: The added hardcoded `max-width: 120px;` can break
in non-English locales (longer text) and is not consistent with theme sizing;
replace the fixed pixel value with a theme-based value so the width scales with
the app's spacing units.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
