Copilot commented on code in PR #36669:
URL: https://github.com/apache/superset/pull/36669#discussion_r2624387718
##########
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx:
##########
@@ -242,7 +245,11 @@ function ListViewCard({
{title}
</TitleLink>
</Tooltip>
- {titleRight && <TitleRight>{titleRight}</TitleRight>}
+ {titleRight && (
+ <Tooltip title={titleRight}>
+ <TitleRight>{titleRight}</TitleRight>
+ </Tooltip>
+ )}
Review Comment:
The new tooltip wrapper and truncation behavior for titleRight should be
covered by tests. Consider adding a test case that verifies: 1) titleRight is
rendered when provided, 2) long text is truncated with ellipsis, and 3) tooltip
appears with the full text on hover. This would help prevent regressions of the
overlap fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
