innovark37 opened a new pull request, #36671:
URL: https://github.com/apache/superset/pull/36671
### SUMMARY
This PR fixes visual inconsistencies in the three-dot menu buttons across
different card types on the Home page. Previously, Saved Queries cards had
different styling compared to Dashboard and Chart cards, creating an
inconsistent user experience.
#### Changes
- Removed extra wrapper div (`<QueryData>`) around the actions container
- Fixed icon color: Changed from `iconColor={theme.colorText}` to standard
`iconSize="xl"` to match other cards
- Fixed icon alignment: Removed `vertical-align: baseline` from the Share
menu item icon
- Standardized spacing: Menu button now has consistent margins/padding like
other card types
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
<img width="406" height="443" alt="{0FD9BC70-003F-4131-8ED6-63DA8E053B7D}"
src="https://github.com/user-attachments/assets/f552c925-971b-49e5-9c28-94236eff95cd";
/>
AFTER
<img width="451" height="441" alt="{932666B0-72D9-470A-BD29-759A05056C14}"
src="https://github.com/user-attachments/assets/33443e58-8762-40ed-b09f-2c6941920a5f";
/>
### TESTING INSTRUCTIONS
1. Navigate to SQL Lab
2. Create and save a query
3. Navigate to Home (/)
4. Verify saved query appears on Home page
5. Compare the three-dot button on your Saved Query card with three-dot
buttons on Dashboard and Chart cards
- Verify all buttons have identical margins/padding from card edges
- Verify all icons have same color and size
- Verify icon alignment in menu items
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
