mistercrunch commented on a change in pull request #7773: Improve examples & 
related tests
URL: 
https://github.com/apache/incubator-superset/pull/7773#discussion_r300842303
 
 

 ##########
 File path: superset/models/core.py
 ##########
 @@ -665,12 +665,13 @@ def export_dashboards(cls, dashboard_ids):
             )
             make_transient(copied_dashboard)
             for slc in copied_dashboard.slices:
+                make_transient(slc)
 
 Review comment:
   This looked like a pretty bad bug, exporting dashboards would mutate slices 
in odd ways.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to