mistercrunch commented on a change in pull request #7773: Improve examples &
related tests
URL:
https://github.com/apache/incubator-superset/pull/7773#discussion_r300842330
##########
File path: superset/tasks/cache.py
##########
@@ -75,13 +73,13 @@ def get_form_data(chart_id, dashboard=None):
return form_data
-def get_url(params):
+def get_url(chart):
"""Return external URL for warming up a given chart/table cache."""
- baseurl =
"http://{SUPERSET_WEBSERVER_ADDRESS}:{SUPERSET_WEBSERVER_PORT}/".format(
Review comment:
`http://` here seemed bad to me as someone might have `https://` decided to
remove it @betodealmeida
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
