michael-s-molina commented on code in PR #36686:
URL: https://github.com/apache/superset/pull/36686#discussion_r2634764214
##########
superset-frontend/src/dashboard/util/activeAllDashboardFilters.ts:
##########
@@ -31,7 +32,21 @@ export const getRelevantDataMask = (
Object.fromEntries(
Object.values(dataMask)
.filter(item => item[prop])
- .map(item => [item.id, item[prop]]),
+ .map(item => {
+ const value = item[prop];
Review Comment:
I think we have two options:
1. Given the "relevant" word on `getRelevantDataMask`, we might consider
that `clientView` is not relevant and your solution would be correct. This
means that `clientView` is never relevant for any caller of this function which
might be true given that there's only one caller currently
(`DashboardPage.tsx`).
2. If `clientView` might be useful for other callers, we could change
`DashboardPage.tsx` and omit the property there:
```
const selectRelevantDatamask = createSelector(
(state: RootState) => state.dataMask,
dataMask => omit(getRelevantDataMask(dataMask, 'ownState'),
['clientView']),
);
```
I'm good with either solution, so I'm approving the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
