rajatmohan22 commented on issue #36795: URL: https://github.com/apache/superset/issues/36795#issuecomment-3683878730
Hey @innovark37, Thanks for bringing this up, and thanks @dosubot for the clear explanation. 😄 I'd be happy to help with this problem. This is how I plan to do it: The suggested method: - Find the three-dot menu button part that is used in chart headers. It is probably in the chart controls or menu trigger part. - To reproduce the problem on your own computer, use a custom theme with a linkHoverBg that isn't transparent, as shown. - Change the styles of the buttons so that the horizontal padding is the same on all of them (for example, add back the right and left padding). This will keep the icon visually centered even when a hover background is added. - Check to see if buttonStyle="link" makes sense for this menu toggle. If it doesn't, switch to a button style that does to avoid layout problems. - Check the fix in both the default and dark themes to make sure it doesn't break any existing styles. - To make things clearer, add screenshots of the PR before and after. If this sounds good, I'll get started on a patch right away. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
