vighneshtule commented on issue #36795: URL: https://github.com/apache/superset/issues/36795#issuecomment-3705872036
Hi @innovark37! 👋 I see that @rajatmohan22 might not have been able to get to this yet. I'm interested in picking this up! My plan aligns with the discussion above: 1. **Reproduction**: I'll verify the alignment issue by applying a custom theme with a non-transparent `linkHoverBg`. 2. **Fix**: I've located the code in `SliceHeaderControls/index.tsx` where `padding-right: 0px` is applied. I'll adjust the padding to be symmetrical to ensure the icon remains centered. 3. **Review**: I'll also check if `buttonStyle="link"` is the best semantic choice here. 4. **Verification**: I'll test the fix across default, dark, and custom themes to ensure no regressions. I'll get a PR up shortly! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
