bito-code-review[bot] commented on code in PR #36760:
URL: https://github.com/apache/superset/pull/36760#discussion_r2642210349
##########
superset-frontend/src/explore/controlUtils/standardizedFormData.ts:
##########
@@ -211,13 +211,15 @@ export class StandardizedFormData {
publicFormData[key] = exploreState.form_data[key];
}
});
- const targetControlsState = getControlsState(exploreState, {
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ const targetControlsState = getControlsState(exploreState as any, {
Review Comment:
<!-- Bito Reply -->
Yes, the explanation is valid — the casts are necessary because
`getControlsState()` returns `Record<string, unknown>`, which doesn't match the
expected `ControlStateMapping` type. Updating the function's return type across
multiple files is out of scope for this JS→TS migration PR. It's properly
documented as technical debt with eslint-disable comments.
##########
superset-frontend/src/explore/components/controls/SelectControl.tsx:
##########
@@ -316,11 +370,9 @@ export default class SelectControl extends PureComponent {
}
`}
>
- <Select {...selectProps} />
+ {/* eslint-disable-next-line @typescript-eslint/no-explicit-any */}
+ <Select {...(selectProps as any)} />
Review Comment:
<!-- Bito Reply -->
Your explanation is accurate. SelectControl handles diverse input types
(strings, numbers, objects), leading to complex typing. The `any` cast and
eslint-disable mark this as technical debt for future controls typing
improvements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
