rusackas commented on code in PR #36760:
URL: https://github.com/apache/superset/pull/36760#discussion_r2643681280
##########
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnMetricSelect.tsx:
##########
@@ -344,10 +345,14 @@ function DndColumnMetricSelect(props:
DndColumnMetricSelectProps) {
onChange(multi ? newValues : newValues[0]);
}}
onRemoveMetric={onClickClose}
- columns={columns}
- savedMetrics={savedMetrics}
- savedMetricsOptions={savedMetrics}
- datasource={datasource}
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ columns={columns as any}
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ savedMetrics={savedMetrics as any}
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ savedMetricsOptions={savedMetrics as any}
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ datasource={datasource as any}
onMoveLabel={onShiftOptions}
onDropLabel={() => {}}
type={`${DndItemType.AdhocMetricOption}_${name}_${label}`}
Review Comment:
The `as any` casts and eslint-disables document type incompatibilities
between the DnD library and our typed props. The DndColumnMetricSelect
component interfaces with react-dnd which has complex generic types. Proper
typing would require extensive refactoring of the drag-and-drop infrastructure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
