codeant-ai-for-open-source[bot] commented on code in PR #36829: URL: https://github.com/apache/superset/pull/36829#discussion_r2645133350
########## docs/docs/configuration/networking-settings.mdx: ########## @@ -51,7 +51,7 @@ Restart Superset for this configuration change to take effect. #### Making a Dashboard Public -1. Add the `'DASHBOARD_RBAC': True` [Feature Flag](https://github.com/apache/superset/blob/master/RESOURCES/FEATURE_FLAGS.md) to `superset_config.py` +1. Add the `'DASHBOARD_RBAC': True` [Feature Flag](/docs/configuration/configuring-superset#feature-flags) to `superset_config.py` Review Comment: **Suggestion:** The inline fragment uses quotes and a colon within the prose which is easy to mis-copy and cause syntax mistakes; provide a clear inline code assignment alternative (single-line assignment) so readers can copy a minimal, correct statement. [possible bug] **Severity Level:** Critical 🚨 ```suggestion 1. Alternatively, you can set the flag with a single-line assignment in `superset_config.py`: ```python FEATURE_FLAGS['DASHBOARD_RBAC'] = True ``` ``` <details> <summary><b>Why it matters? ⭐ </b></summary> A single-line assignment (FEATURE_FLAGS['DASHBOARD_RBAC'] = True) is a minimal, copy-pastable example that reduces ambiguity. It's helpful for users who already have FEATURE_FLAGS defined; the doc should still note the need to create the dict if it doesn't exist. </details> <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/docs/configuration/networking-settings.mdx **Line:** 54:54 **Comment:** *Possible Bug: The inline fragment uses quotes and a colon within the prose which is easy to mis-copy and cause syntax mistakes; provide a clear inline code assignment alternative (single-line assignment) so readers can copy a minimal, correct statement. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
