codeant-ai-for-open-source[bot] commented on PR #36895: URL: https://github.com/apache/superset/pull/36895#issuecomment-3708256626
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36895/files#diff-d987d4addee4ccb4cccae5bb4376bdf7915776d6e8631f9a777abfa98c08c9a0R1413-R1414'><strong>Negative size risk</strong></a><br>Subtracting padding from measured table sizes can produce negative/very small width or height values (table initial state is 0). Passing negative sizes to the virtualized DataTable may cause layout glitches or unexpected behavior. Clamp computed sizes to >= 0 before passing to child components.<br> - [ ] <a href='https://github.com/apache/superset/pull/36895/files#diff-d987d4addee4ccb4cccae5bb4376bdf7915776d6e8631f9a777abfa98c08c9a0R1413-R1422'><strong>Inconsistent layout inputs</strong></a><br>The DataTable dimensions now use adjusted content size (widthFromState - padding) while other layout decisions (e.g., maxPageItemCount) still use the original `width` prop. This can cause inconsistent behavior/line-wrapping between the table body and controls. Consider computing a single adjusted content width/height and reuse it across layout logic.<br> - [ ] <a href='https://github.com/apache/superset/pull/36895/files#diff-3a1680cdfe4669587cb7013f1f21b93a0ea2d049aa110e2e34bd16aa733c7607R24-R24'><strong>Layout / overflow</strong></a><br>Adding padding to the top-level chart container increases the element's total size; if the container or table children use width: 100% and the box-sizing is content-box (default), the padding will cause overflow and can produce horizontal/vertical scrollbars. Verify the table rendering and the JS sizing logic consider padding (or set box-sizing to border-box) so the table fits reliably without visual regressions.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
