codeant-ai-for-open-source[bot] commented on code in PR #36895:
URL: https://github.com/apache/superset/pull/36895#discussion_r2659800591
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -1410,8 +1410,8 @@ export default function TableChart<D extends DataRecord =
DataRecord>(
pageSize={pageSize}
serverPaginationData={serverPaginationData}
pageSizeOptions={pageSizeOptions}
- width={widthFromState}
- height={heightFromState}
+ width={widthFromState - theme.sizeUnit * 10}
+ height={heightFromState - theme.sizeUnit * 10}
Review Comment:
**Suggestion:** Passing potentially negative width/height to `DataTable` can
produce invalid layout or runtime assumptions; clamp the computed size to zero
so negative values are never passed. Use Math.max(0, ...) when subtracting
padding. [logic error]
**Severity Level:** Minor ⚠️
```suggestion
width={Math.max(0, widthFromState - theme.sizeUnit * 10)}
height={Math.max(0, heightFromState - theme.sizeUnit * 10)}
```
<details>
<summary><b>Why it matters? ⭐ </b></summary>
This is a valid and pragmatic safety improvement — tableSize initializes at
0 so subtracting theme.sizeUnit * 10 can produce negative values on first
render. Clamping to Math.max(0, ...) prevents passing negative sizes to
DataTable which could produce invalid layout or runtime issues. It's a small,
safe change that doesn't require broader refactors.
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
**Line:** 1413:1414
**Comment:**
*Logic Error: Passing potentially negative width/height to `DataTable`
can produce invalid layout or runtime assumptions; clamp the computed size to
zero so negative values are never passed. Use Math.max(0, ...) when subtracting
padding.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
