codeant-ai-for-open-source[bot] commented on PR #37017: URL: https://github.com/apache/superset/pull/37017#issuecomment-3730039485
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/37017/files#diff-b4d2de68c8a3b04879772237085ede1b49a6908b6f2890a9ab1aaeae9e18b854R517-R517'><strong>Value type compatibility</strong></a><br>The new value prop passes `filterState.value` directly for single-select. `filterState.value` can be an array (the code often stores values as arrays) or other types (boolean). Passing an array to a single-select can lead to unexpected behavior or an empty display. Ensure the Select receives the type it expects for single-select (a scalar or undefined/null).<br> - [ ] <a href='https://github.com/apache/superset/pull/37017/files#diff-f7c1e2c13ad058dd29615eb020a5d5e6e0f29d59057c1747d397724d71e8759fR655-R656'><strong>Flaky element selection</strong></a><br>The test selects the combobox using an index (getAllByRole('combobox')[0]) which is brittle if other comboboxes appear in the render. This can make the test flaky and ambiguous about which combobox is being interacted with. Prefer selecting by accessible name or narrowing the query to the combobox that contains the expected options.<br> - [ ] <a href='https://github.com/apache/superset/pull/37017/files#diff-f7c1e2c13ad058dd29615eb020a5d5e6e0f29d59057c1747d397724d71e8759fR660-R677'><strong>Missing UI-level assertion</strong></a><br>The test asserts that setDataMask is called with a filter containing boolean false, but it doesn't assert the UI state change that motivated the PR (e.g., that the Apply button is enabled or that the selected label appears). Adding a UI assertion reduces the chance of regressions where the data-layer call still happens but the Apply button remains disabled or the user can't confirm the selection.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
