rebenitez1802 commented on code in PR #37017:
URL: https://github.com/apache/superset/pull/37017#discussion_r2687392033
##########
superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx:
##########
@@ -602,6 +602,84 @@ describe('SelectFilterPlugin', () => {
expect(options[2]).toHaveTextContent('alpha');
});
+ test('Select boolean FALSE value in single-select mode', async () => {
Review Comment:
The codebase is [migrating away from nested describe()
blocks](https://github.com/apache/superset/blob/master/CLAUDE.md#testing-strategy-migration)
to flatten test structure. While the existing file uses the old pattern, your
new test could help start this migration by being self-contained at the top
level:
// Move this outside the describe() block, after line 680
test('Select boolean FALSE value in single-select mode', async () => {
const setDataMaskMock = jest.fn();
const testProps = {
...selectMultipleProps, // import this const from top of file
formData: {
...selectMultipleProps.formData,
multiSelect: false,
groupby: ['is_active'],
},
// ... rest of your test setup
};
// ... rest of your test
});
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
